Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove init buttons #3246

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Remove init buttons #3246

merged 5 commits into from
Oct 14, 2020

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented Oct 6, 2020

refs: #3244

Copy link
Member

@tabacitu tabacitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also included some other changes about the select_from_array field, by mistake. Right?

One day @pxpm , I will convince you to try to use https://git-fork.com .
I was blind but now I see. I no longer use the command line for Git.
One day you will see the light too!!! 🤣

@tabacitu tabacitu added the Bug label Oct 6, 2020
@pxpm
Copy link
Contributor Author

pxpm commented Oct 7, 2020

@tabacitu It's open .. I just need to get used to it a little bit more hehe, thanks for the tip \o

Removed the unwanted code and added the tests for the setRouteName()

Best,
Pedro

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 2 updated code elements

Copy link
Member

@tabacitu tabacitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR! Reviewed, tested, everything's AOK now.

@tabacitu tabacitu merged commit 2f16513 into master Oct 14, 2020
@tabacitu tabacitu deleted the remove-init-buttons branch October 14, 2020 13:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants