Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed crud\inc\form_save_buttons.blade.php file code alignment issue #3305

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Fixed crud\inc\form_save_buttons.blade.php file code alignment issue #3305

merged 1 commit into from
Nov 8, 2020

Conversation

senthur-kumaran
Copy link

When i looked the file it's very difficult to understand the code. Because code isn't aligned properly. So i aligned the code properly now it easy for everyone to understand.
Before
Before
Now
Now

@welcome
Copy link

welcome bot commented Nov 4, 2020

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@pxpm
Copy link
Contributor

pxpm commented Nov 6, 2020

Hello @senthur1994

Thank you for your submission.

I agree that having proper-aligment would improve the readability of the code.

I will be marking this ready for merge.

Best,
Pedro

@pxpm pxpm self-requested a review November 6, 2020 13:13
@tabacitu
Copy link
Member

tabacitu commented Nov 8, 2020

Thank you @senthur1994 & @pxpm . Merged.

We do have this problem in quite a few files, indeed. It's something that @promatik mentioned that it's bothering him too. I do wish we could just go ahead and fix all of it, and keep the same standard. I was hoping StyleCI would do that, but apparently

  • it only does it for the files that are modified inside PRs, so files will only get better as we work on them;
  • it does a good job for PHP, not so much for HTML, JS, etc;

Also, we can't just run a fixer on all files, because then it would make all PRs unmergeable. Soo... what we could do is make sure to merge as many PRs as possible, then run a fixer on all files.

@tabacitu tabacitu merged commit b8d6793 into Laravel-Backpack:master Nov 8, 2020
@welcome
Copy link

welcome bot commented Nov 8, 2020

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

  • give your opinion on other Github Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-)
Cheers!

--
Justin Case
The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please apply for free licenses and mention this PR. You scratch my back, I scratch your back. Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants