Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Composer Suggestions - add main addons and tools as suggestions in composer.json #3307

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Nov 4, 2020

When doing a composer install it should say something like this (see last line):
Screenshot 2020-11-04 at 17 02 37

It's a small line, that not many people read. But if you do composer suggest like it recommends, you'd get an output like this:
Screenshot 2020-11-04 at 17 05 03

Which is pretty cool. This PR should add our NOT REQUIRED, but NICE-TO-HAVE packages to this output. So that people who run this also learn a little bit more about the packages we tell people to install across the Backpack docs.

I think that's a good place as any to communicate to people some of the addons we have, that they might want to use. Now, we do have to draw the line somewhere... so:

  • I don't think we'll ever include 3rd party add-ons here; 1st party (backpack/digitallyhappy), sure; 2nd party (backpack veterans)... maybe; but 3rd party... probably not smart;
  • I didn't include addons like NewsCRUD, BackupManager, etc because... while useful, those packages only cover a very particular use case;
  • the packages that I did include here are mentioned throughout the docs, which might be a little too hidden; they're mentioned inside that particular feature; this would make them a little more visible, point people to that particular feature we do offer, but as an optional addon;

I don't know whether this should be merged. Not sure it adds much value, or if anybody actually uses composer suggest. Then again... it wouldn't hurt... I don't know...

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

Copy link
Contributor

@DoDSoftware DoDSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it and certainly couldn't hurt

@tabacitu tabacitu requested review from promatik and pxpm November 8, 2020 11:58
@tabacitu tabacitu changed the title add main addons and tools as suggestions in composer.json Use Composer Suggestions - add main addons and tools as suggestions in composer.json Nov 8, 2020
Copy link
Contributor

@promatik promatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nice to have, maybe later we can keep the list updated with the Top Rated addons.

@tabacitu tabacitu merged commit a117a32 into master Nov 16, 2020
@tabacitu tabacitu deleted the add-suggest-composer-section branch November 16, 2020 13:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants