Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow string for values / options parameter #5744

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

susanu
Copy link
Contributor

@susanu susanu commented Jan 7, 2025

As the title say.

@jcastroa87
Copy link
Member

Hello @susanu

Thanks for the PR I will ask @pxpm to review and if everything is ok will be merged.

Cheers.

@jcastroa87 jcastroa87 requested a review from pxpm January 8, 2025 12:52
@pxpm
Copy link
Contributor

pxpm commented Jan 14, 2025

Hey @susanu thanks for the PR.

AFAIK, this options are only used by filters that need them. If you pass a string to it, the filter is a "single value" filter, so why not use the simple filter instead?

I am just trying to figure out the use case for a string in these options. Can you provide me some example ?

Cheers

@susanu
Copy link
Contributor Author

susanu commented Jan 14, 2025

Please check https://backpackforlaravel.com/docs/6.x/crud-filters#select2_ajax-1
When you use select2_ajax filter the "values" is an url

@pxpm
Copy link
Contributor

pxpm commented Jan 16, 2025

Thanks @susanu 🙏

@pxpm pxpm merged commit 057c9d9 into Laravel-Backpack:main Jan 16, 2025
2 of 3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants