Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove class with --var in it #5760

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

NuktukDev
Copy link
Contributor

@NuktukDev NuktukDev commented Jan 28, 2025

WHY

BEFORE - What was wrong? What was happening before this PR?

image

AFTER - What is happening after this PR?

image

HOW

How did you achieve that, in technical terms?

Removed a class being added that doesn't exist.

Is it a breaking change?

No

How can we test the before & after?

??

Notes:

Using tablr theme

@pxpm
Copy link
Contributor

pxpm commented Jan 28, 2025

Hum.. I see. Thanks @NuktukDev

I think we shouldn't remove the class entirely, that's used by "coreui-v2" theme, so that you can set switch colors like: primary etc. (it only works on that theme tho).

I am sure some people are relying on that feature so we can't remove it completely, but we can avoid displaying the class in case the $field['color'] starts with # (an hex color), or var( a variable color.

Are you willing to do the changes in this PR ?

Thanks again 🙏

@karandatwani92 karandatwani92 requested a review from pxpm January 29, 2025 09:51
@karandatwani92 karandatwani92 added the Size: XS 1 hour label Jan 29, 2025
@pxpm pxpm mentioned this pull request Jan 31, 2025
@pxpm pxpm merged commit 8b714cb into Laravel-Backpack:main Jan 31, 2025
2 checks passed
Copy link

welcome bot commented Jan 31, 2025

WHOOP-WHOOP! Congrats, your first PR on this repo has officially been merged.

party

You should also receive an email inviting you to the Community Members team. That's where we, committed community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

  • give your opinion on other GitHub Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-)
Cheers!

--
Justin Case
The Backpack Robot

@pxpm
Copy link
Contributor

pxpm commented Jan 31, 2025

Thanks @NuktukDev much appreciated.

I've just made the changes I requested and merged the PR.

Cheers

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Size: XS 1 hour
Development

Successfully merging this pull request may close these issues.

3 participants