fix fake field casting when translations are enabled #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please @pxpm , would it be possible to merge in backpack version 5 too? On my environment I currently cannot upgrade to version 6. |
|
Hello @mrinaldidfs I am sorry but we are not pushing patch fixes to v5 for a long time now. I'd suggest you lock Cheers |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Spatie/Laravel-Translatable introduced a Breaking Change (IMO), and broke our functionality. TLDR: Casts are now "forced" into the model, and our functionality was expecting the previous behavior (casts only available upon calling
getCasts()).AFTER - What is happening after this PR?
I've added a workaround in our Fake Fields functionality, so hopefully we can circumvent this issue.
HOW
How did you achieve that, in technical terms?
Check if the column is translatable, if it is, ignore the cast.
Is it a breaking change?
I don't think so, no.