fix(FormBuilder): correct radio checked state for falsy values (fixes #650) #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes incorrect handling of radio inputs with falsy values (
0,false, empty string) by replacing!$requestwithis_null($request)inFormBuilder.php.Fixes #650
Why is this needed?
value="0"showed as unchecked despite being selected!$requestevaluated all falsy values (0/false/"") as "missing"is_null()specifically detects only truly missing fields (null)Changes Made
!$requestwithis_null($request)ingetRadioCheckedState()Test Case | Before | After
value="0" | ❌ | ✅
value="1" | ✅ | ✅
Field not submitted | ✅ | ✅
|
Fixes #650