ws4py broken using cherrypy>=11.1.0

[matt-hammond-001]

ws4py appears to be broken when using latest ws4py and cherrypy>=11.1.0 (installed via pip). Specifically I'm using python 2.7 and I've got these package versions installed:

• ws4py==0.4.2
• cheroot==5.9.1

I've tested with CherryPy==

• Works: 10.2.1 | 10.2.2 | 11.0.0
• Broken: 11.1.0 | 11.2.0 | 12.0.0 | 12.0.1

When running the simple server example I get the following error when I make a websocket connection to this server:

127.0.0.1 - - [23/Nov/2017:14:58:23] "GET /ws HTTP/1.1" 101 - "" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0"
[23/Nov/2017:14:58:23] ENGINE AttributeError("'NoneType' object has no attribute 'recv'",)
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/cheroot/server.py", line 1112, in communicate
    req.parse_request()
  File "/usr/local/lib/python2.7/dist-packages/cheroot/server.py", line 638, in parse_request
    success = self.read_request_line()
  File "/usr/local/lib/python2.7/dist-packages/cheroot/server.py", line 676, in read_request_line
    request_line = self.rfile.readline()
  File "/usr/local/lib/python2.7/dist-packages/cheroot/server.py", line 233, in readline
    data = self.rfile.readline(256)
  File "/usr/local/lib/python2.7/dist-packages/cheroot/makefile.py", line 233, in readline
    data = self.recv(self._rbufsize)
  File "/usr/local/lib/python2.7/dist-packages/cheroot/makefile.py", line 87, in recv
    data = self._sock.recv(size)
AttributeError: 'NoneType' object has no attribute 'recv'

[noam-graetz]

i have identified and fixed the problem... currently pending (pull request #236 ).

[matt-hammond-001]

@noam-graetz - many thanks. Have just verified that this does seem to fix the issue I was seeing.

[noam-graetz]

it should :) because we had the same problem... took me a while to find out, and i was amused on the actual problem when i found it.

…

On Mon, Dec 11, 2017 at 1:06 PM, Matt Hammond ***@***.***> wrote: @moan-graetz - many thanks. Have just verified that this does seem to fix the issue I was seeing. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#235 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AftuOR5r1Ku_OKBBNJcx7O4R3gq_Sj42ks5s_Qy3gaJpZM4Qo5Cd> .

-- *Noam Graetz* Chief Software Architect *Firmitas Cyber Solutions (Israel) Ltd.* *M.* +972 54 495 6898 <%2B972%2054%20593%207777> *T.* +972 72 215 1170 ext 204 *E.* noam.graetz@firmitas- <rami.shaft@firmitas.solutions>cs.com <http://www.firmitas.solutions/>

--

------------------------------ The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us at legal@firmitas-cs.com immediately and then delete it from your system. Firmitas is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.

[h3llrais3r]

@Lawouach I've just tested version 0.4.3 with latest cherrypy version 13.1.0 and I confirm it's fixed.
Thanks for the release.

[matt-hammond-001]

@Lawouach @noam-graetz ... have also just tested with ws4py==0.4.3 and cherrypy==13.1.0. Looks good.

Many thanks. Closing this issue as it is now resolved.