[v2] Disperser server GetBlobCommitment endpoint
#899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
reviewed
Nov 15, 2024
| @@ -161,6 +162,10 @@ func RunDisperserServer(ctx *cli.Context) error { | |||
| bucketName := config.BlobstoreConfig.BucketName | |||
| logger.Info("Blob store", "bucket", bucketName) | |||
| if config.DisperserVersion == V2 { | |||
| prover, err := prover.NewProver(&config.EncodingConfig, true) | |||
There was a problem hiding this comment.
The prover setup takes around ~20 seconds with 16 cpus since we need to load the G2 points. Also is the disperser still a singleton in V2?
There was a problem hiding this comment.
I don't think it has to be a singleton anymore now that payments aren't handled locally. @mooselumph is that correct?
dmanc
reviewed
Nov 15, 2024
disperser/apiserver/server_v2.go
Outdated
| if s.prover == nil { | ||
| return nil, api.NewErrorUnimplemented() | ||
| } | ||
| if len(req.GetData()) == 0 { |
There was a problem hiding this comment.
Should we have bounds check on the largest supported blob size?
ian-shim
force-pushed
the
get-commitment-endpoint
branch
from
eb629a2 to
9d13075
Compare
cody-littley
approved these changes
Nov 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Loads a prover with G2 points and computes commitment on
GetBlobCommitmentrequestChecks