Use power of 2 for blob length #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
approved these changes
Nov 20, 2024
ian-shim
approved these changes
Nov 20, 2024
mooselumph
commented
Nov 20, 2024
| @@ -128,7 +128,7 @@ func (g *ParametrizedProver) GetCommitments(inputFr []fr.Element) (*bn254.G1Affi | |||
| start := time.Now() | |||
| commit, err := g.Computer.ComputeCommitment(inputFr) | |||
| commitmentChan <- commitmentResult{ | |||
| Commitment: *commit, | |||
There was a problem hiding this comment.
This causes a nil-pointer dereference error when there is an error.
mooselumph
commented
Nov 20, 2024
| @@ -32,19 +32,19 @@ type rsEncodeResult struct { | |||
| } | |||
|
|
|||
| type lengthCommitmentResult struct { | |||
| LengthCommitment bn254.G2Affine | |||
| LengthCommitment *bn254.G2Affine | |||
There was a problem hiding this comment.
Is there any issue with using pointers here?
|
@cody-littley FYI, this is the change that will make |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks