Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Metrics framework churner #934

Merged
merged 22 commits into from
Nov 27, 2024
Merged

Metrics framework churner #934

merged 22 commits into from
Nov 27, 2024

Conversation

cody-littley
Copy link
Contributor

@cody-littley cody-littley commented Nov 25, 2024 •
edited
Loading

Why are these changes needed?

As part of the discussion around the metrics framework, @dmanc requested that I migrate the churner to use the new framework (since it will survive after v2 is enabled).

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@cody-littley
Created new metrics framework in common.
07f0cee 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Got latency metrics working.
e444849 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Added counter.
538470c 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
All metric types working.
1083c94 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Added auto-gauge.
31c4a43 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Add mock metrics.
7d826a8 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Auto-generate metrics docs.
49b11e1 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Pass unit as part of promethious metadata.
2d6c116 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Use ticker instead of sleeping.
fbc7bc1 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Made suggested changes.
02e710d 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Improve documentation.
0217da7 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
lint
b0fd072 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
incremental progress
72834e3 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Incremental progress.
8f28ec0 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Add labels to counts
bcdd296 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Finish new label system.
1a36247 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Improve documentation for labels.
b28e075 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Move churner to new metrics framework.
dc82a66 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley cody-littley self-assigned this Nov 25, 2024
@cody-littley cody-littley mentioned this pull request Nov 25, 2024
Merged
5 tasks
@cody-littley
Update metric name.
af7284d 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Merge branch 'master' into metrics-framework-churner
53bbb85 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Generate metrics documentation.
974fbc5 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley
Cleanup
0952f84 
Signed-off-by: Cody Littley <cody@eigenlabs.org>
@cody-littley cody-littley marked this pull request as ready for review November 26, 2024 20:38
dmanc
dmanc approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@dmanc dmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure to update any dashboards with the updated metric but otherwise lgtm!

@cody-littley cody-littley merged commit 53fd80d into Layr-Labs:master Nov 27, 2024
6 checks passed
@cody-littley cody-littley deleted the metrics-framework-churner branch November 27, 2024 15:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@ian-shim ian-shim Awaiting requested review from ian-shim

@jianoaix jianoaix Awaiting requested review from jianoaix

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cody-littley @dmanc