-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: separate interface and service in bls_aggr
#363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce logic is now in run()
MegaRedHand
reviewed
Feb 18, 2025
MegaRedHand
reviewed
Feb 18, 2025
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
pablodeymo
previously approved these changes
Feb 18, 2025
MegaRedHand
reviewed
Feb 18, 2025
MegaRedHand
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR refactors the BLS Aggregator by separating its interface from the internal service logic.
ServiceHandle
to serve as the interface for communicating with the BLS Aggregator service. This interface provides two new methodsinitialize_task
: Sends a message to the BLS Aggregator Service to initialize a new task.process_signature
: Sends a message to the BLS Aggregator Service to process a signature.AggregateReceiver
to receive the aggregated responses from the BLS Aggregator Service.BlsAggregatorService
BlsAggregatorService
:start
: Starts the BLS Aggregator Service running the main loop in background. This method return a tuple withServiceHandle
andAggregateReceiver
. User can use these methods to interact with the service.run
: Runs the main loop of the BLS Aggregator Service.initialize_new_task
andprocess_new_signature
functions since their logic is now integrated inrun()
.Close #257
Reviewer Checklist
changelog-X
labels (if applies)