New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix memory leak #12

Merged

LePips merged 2 commits into LePips:main from Mo7amedFouad:main

Dec 15, 2022

Contributor

Mo7amedFouad commented Nov 20, 2022

The proxy object shouldn't hold a strong reference to VLCMediaPlayer and UIVLCVideoPlayerView

Mo7amedFouad added 2 commits

November 20, 2022 09:58


          Update Proxy.swift

e647035


          Update Proxy.swift

a38c335

Owner

LePips commented Nov 21, 2022

Thanks for taking a look at this, I think that UIVLCVideoPlayerView.proxy can also have a weak reference as well.

Is there a minimal reproducible example where a leak is experienced?

LePips merged commit 79fc6f3 into LePips:main

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet