Feat: prepare rename request #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeansidharta
force-pushed
the
feat/prepare-rename-request
branch
from
74d26b5 to
47f6a0b
Compare
|
Thanks~ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Prepare Rename Request.
The request handler is essentially a CTRL + C, CTRL + V of the rename request's beginning (can be seen here), but instead of showing an error message, it just returns
nullon most cases. I wanted to isolate the logic into a function (something likefn can_rename_node (node: &Node, bfile: &ParsedCode) -> bool) and reuse both in the Rename handler and the Prepare Rename Handler, but couldn't think of a good way to abstract it. So I'll just create this lazy PR and wait for feedback from the maintainer.