Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(LIVE-16730): enable Swap deeplinks on LLM #9202

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

ejaycoleman
Copy link
Contributor

@ejaycoleman ejaycoleman commented Feb 12, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

To enable swap app LLM deeplinks, two problems needed to be fixed:

  • an infinite useEffect loop within the useDappAccountLogic function
  • the deeplink parameter has different casing on LLM (customDappURL) compared to LLD (customDappUrl)

Kapture 2025-02-17 at 10 14 12

❓ Context

  • JIRA or GitHub link:
    LIVE-16730 Prevent infinite useEffect loop on Swap deeplinks

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 10:00am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 10:00am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 10:00am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 10:00am

@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common labels Feb 12, 2025
@ejaycoleman ejaycoleman force-pushed the feat/LIVE-16730-enable-deeplinks-on-llm branch from 70815a0 to e1d1770 Compare February 12, 2025 11:13
@ejaycoleman ejaycoleman marked this pull request as ready for review February 12, 2025 12:15
@ejaycoleman ejaycoleman requested a review from a team as a code owner February 12, 2025 12:15
CremaFR
CremaFR previously approved these changes Feb 12, 2025
@ejaycoleman ejaycoleman requested a review from a team as a code owner February 17, 2025 10:15
@live-github-bot live-github-bot bot removed the common Has changes in live-common label Feb 17, 2025
@ejaycoleman ejaycoleman force-pushed the feat/LIVE-16730-enable-deeplinks-on-llm branch from 06fda7b to a65d627 Compare February 17, 2025 10:19
Copy link

socket-security bot commented Feb 17, 2025

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/jotai-scope@0.7.3 environment 0 83.9 kB daishi

View full report↗︎

Justkant
Justkant previously approved these changes Feb 17, 2025
@ejaycoleman ejaycoleman force-pushed the feat/LIVE-16730-enable-deeplinks-on-llm branch from d920a2f to 9906b38 Compare February 19, 2025 09:53
@ejaycoleman ejaycoleman added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
@ejaycoleman ejaycoleman added this pull request to the merge queue Feb 19, 2025
Merged via the queue into develop with commit 91fd71d Feb 19, 2025
59 of 60 checks passed
@ejaycoleman ejaycoleman deleted the feat/LIVE-16730-enable-deeplinks-on-llm branch February 19, 2025 14:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants