Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[QAA-471][Detox] Allure reporting improvements #9287

Open
wants to merge 6 commits into from
Open

[QAA-471][Detox] Allure reporting improvements #9287

wants to merge 6 commits into from
+201 −190

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Feb 20, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Allure reporting

📝 Description

  • Decouple allure speculos reporting from mocked tests
  • Don't take logs and screenshots for Detox passing tests
  • Fix tms links when several tickets
  • Fix conditionnal app logs and speculos screenshot by adding a global to get test status
  • Put speculos screenshot in allure test body

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 11:53am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 11:53am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 11:53am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 11:53am

@live-github-bot live-github-bot bot added mobile Has changes in LLM automation CI/CD stuff labels Feb 20, 2025
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review February 20, 2025 09:12
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners February 20, 2025 09:12
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_471_allure-improvments branch from 5e1b5cf to c434349 Compare February 20, 2025 11:00
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_471_allure-improvments branch from c434349 to 68291c1 Compare February 21, 2025 08:39
@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Feb 21, 2025
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_471_allure-improvments branch from 68291c1 to 3b758e3 Compare February 21, 2025 10:22
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_471_allure-improvments branch from 3b758e3 to cecfdc5 Compare February 26, 2025 10:43
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_471_allure-improvments branch from cecfdc5 to 6f7edff Compare February 26, 2025 11:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@abdurrahman-ledger abdurrahman-ledger added this pull request to the merge queue Feb 26, 2025
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@abdurrahman-ledger abdurrahman-ledger added this pull request to the merge queue Feb 26, 2025
Any commits made after this event will not be merged.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

@VicAlbr VicAlbr VicAlbr approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
automation CI/CD stuff common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdurrahman-ledger @LucasWerey @ypolishchuk-ledger @VicAlbr