Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(live-dmk): add LedgerLiveLogger #9333

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fAnselmi-Ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Added LL logger in live-dmk

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 25, 2025 5:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 5:32pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 5:32pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 5:32pm

valpinkman
valpinkman previously approved these changes Feb 25, 2025
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch from 1f84fbb to 54b36e2 Compare February 25, 2025 09:58
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch from 54b36e2 to db82c04 Compare February 25, 2025 13:09
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Feb 25, 2025
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch from db82c04 to 21cac7b Compare February 25, 2025 13:14
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch from 21cac7b to 090355a Compare February 25, 2025 13:26
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch from 090355a to 16c3527 Compare February 25, 2025 14:18
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch from 16c3527 to 10231ba Compare February 25, 2025 14:47
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch from 10231ba to bf15dab Compare February 25, 2025 14:54
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch 2 times, most recently from d0d7f73 to 65327f6 Compare February 25, 2025 16:17
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/live-17151-LedgerLiveLogger-in-liveDMK branch from 65327f6 to 68f2325 Compare February 25, 2025 16:37
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
78.6% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants