Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

✨ LLD - Ledger Sync entry points #9334

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

✨ LLD - Ledger Sync entry points #9334

wants to merge 1 commit into from
+875 −105

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Feb 25, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Added Ledger Sync Entry Points to Onboarding, Settings, Accounts and Manager screens

Scenario Demo
Accounts Entry Point Screenshot 2025-02-25 at 15 59 35
Manager Entry Point not displayed when OS update Screenshot 2025-02-25 at 15 59 44
Manager Entry Point not displayed when app update Screenshot 2025-02-25 at 16 00 10
Manager Entry Point Screenshot 2025-02-25 at 16 00 48
Onboarding Entry Point https://github.com/user-attachments/assets/0cb23bba-1357-4e06-8d16-f92079bcd5b1
Settings Entry Point https://github.com/user-attachments/assets/398851e3-4b28-47ba-865d-5ce6655865a8

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 3:01pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 3:01pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 3:01pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 3:01pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Feb 25, 2025
@cgrellard-ledger cgrellard-ledger force-pushed the feat/lld-ledger-sync-entry-points-added branch 3 times, most recently from d22d5c9 to 4e43d32 Compare February 25, 2025 12:59
@cgrellard-ledger cgrellard-ledger marked this pull request as ready for review February 25, 2025 13:41
@cgrellard-ledger cgrellard-ledger requested review from a team as code owners February 25, 2025 13:41
@cgrellard-ledger cgrellard-ledger force-pushed the feat/lld-ledger-sync-entry-points-added branch 2 times, most recently from 200bbe5 to 80a73c5 Compare February 25, 2025 14:13
@cgrellard-ledger cgrellard-ledger force-pushed the feat/lld-ledger-sync-entry-points-added branch from 80a73c5 to e09d4e8 Compare February 25, 2025 14:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cgrellard-ledger cgrellard-ledger

Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cgrellard-ledger