This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
add Transport#setExchangeTimeout and use it in U2F instead of open timeout #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was a mistake to use the open timeout because the exchange timeout is another concept. moreover, this was a bug that the TransportU2F was expecting a timeout in seconds and not in milliseconds like all other parts. Fixes #65 Technically, this commit is a breaking change because if you were using the U2F timeout, you should now use the .setExchangeTimeout instead. otherwise you will have the default of 30s. We probably will unroll a major release to be safe. NB: some transport does not implement openTimeout / exchangeTimeout at the moment. we will incrementally improve this.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was a mistake to use the open timeout because the exchange timeout is another concept.
moreover, this was a bug that the TransportU2F was expecting a timeout in seconds and not in milliseconds like all other parts. Fixes #65
Technically, this commit is a breaking change because if you were using the U2F timeout, you should now use the .setExchangeTimeout instead. otherwise you will have the default of 30s. We probably will unroll a major release to be safe.
NB: some transport does not implement openTimeout / exchangeTimeout at the moment. we will incrementally improve this.