Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix #156 #157

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Fix #156 #157

merged 3 commits into from
Mar 11, 2021

Conversation

RemiBardon
Copy link
Contributor

@RemiBardon RemiBardon commented Mar 9, 2021 •
edited
Loading

Fixes #156.

@RemiBardon
Copy link
Contributor Author

RemiBardon commented Mar 9, 2021 •
edited
Loading

@Legion2 You still need to:

  • Build distribution from source (generate JS) with ncc
  • Create new tag (release)

@Legion2
Copy link
Owner

Legion2 commented Mar 9, 2021

can you add a test please

@Legion2 Legion2 added the bug Something isn't working label Mar 9, 2021
@RemiBardon
Copy link
Contributor Author

I haven't looked at how you write tests, for now I was editing code on GitHub (no need to clone for such small changes). I'll probably look at it tonight.

@RemiBardon
Copy link
Contributor Author

I'm adding a test. You had forgotten an await statement before an io.cp: src/swagger-ui-action.ts#L66.

@RemiBardon
Copy link
Contributor Author

RemiBardon commented Mar 11, 2021 •
edited
Loading

@Legion2 I added a test ✅

RemiBardon added a commit to MonkiProjects/monki-projects-api-specs that referenced this pull request Mar 11, 2021
@RemiBardon
Temporary fix
1c8082b 
Waiting for Legion2/swagger-ui-action#157 to be merged
Legion2
Legion2 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Owner

@Legion2 Legion2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Legion2 Legion2 merged commit 7622d3f into Legion2:main Mar 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Legion2 Legion2 Legion2 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"No API definition provided." when using swagger-config-file
2 participants
@RemiBardon @Legion2