check if version is valid before parse it - closes #10

LeoIannacone · Jul 1, 2014 · 98f446b · 98f446b
1 parent 53f1e2b
commit 98f446b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/npm2deb/__init__.py b/npm2deb/__init__.py
@@ -425,10 +425,11 @@ def _get_Depends(self):
                     mapper.append_warning('error', dep, 'dependency %s '
                                           'not in debian' % (name))
                 version = dependencies[dep].replace('~', '')
-                if version[0].isdigit():
-                    version = '>= %s' % version
-                elif version == '*' or version == 'latest':
-                    version = None
+                if version:
+                    if version[0].isdigit():
+                        version = '>= %s' % version
+                    elif version == '*' or version == 'latest':
+                        version = None
                 if version:
                     dep_debian = "%s (%s)" % (name, version)
                 else:

diff --git a/tests/npm_coherence.py b/tests/npm_coherence.py
@@ -135,6 +135,11 @@ def test_install_bin(self):
         line = self._get_debfile_line('links', 'mocha')
         self.assertTrue(line == 'usr/lib/nodejs/mocha/bin/mocha usr/bin/mocha')
 
+    def issue_10(self):
+        n = Npm2Deb('lastfm')
+        n.create_base_debian()
+        n.create_control()
+
 
 if __name__ == '__main__':
     unittest.main()