Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update pull_request_template.md #196

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Update pull_request_template.md #196

merged 6 commits into from
Apr 14, 2022

Conversation

mina-atef-00
Copy link
Collaborator

No description provided.

@tristanlatr tristanlatr mentioned this pull request Apr 8, 2022
Open
tristanlatr
tristanlatr requested changes Apr 9, 2022
View reviewed changes
Copy link
Collaborator

@tristanlatr tristanlatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mina-andajos,

Thanks a lot, it looks great.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
mina-atef-00 and others added 2 commits April 9, 2022 12:38
@mina-atef-00 @tristanlatr
Update .github/pull_request_template.md
5c118a9 
Co-authored-by: tristanlatr <19967168+tristanlatr@users.noreply.github.com>
@mina-atef-00
Add model changes checkbox
08e8429
tristanlatr
tristanlatr requested changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@tristanlatr tristanlatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only that breaking change is not a thing for us at the moment, so I'de suggest simply not use that term since we can't define it correctly.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
mina-atef-00 and others added 3 commits April 11, 2022 20:29
@mina-atef-00 @tristanlatr
Update .github/pull_request_template.md
05234a0 
Co-authored-by: tristanlatr <19967168+tristanlatr@users.noreply.github.com>
@mina-atef-00 @tristanlatr
Update .github/pull_request_template.md
2b64f1d 
Co-authored-by: tristanlatr <19967168+tristanlatr@users.noreply.github.com>
@mina-atef-00
Fix typo
8cb4daa
tristanlatr
tristanlatr approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@tristanlatr tristanlatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mina-andajos

@tristanlatr tristanlatr merged commit 5728cde into LesFruitsDefendus:develop Apr 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tristanlatr tristanlatr tristanlatr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mina-atef-00 @tristanlatr