Skip to content

Commit

Permalink
Set MACOSX_DEPLOYMENT_TARGET to 10.7, same as Node.js 10.x
Browse files Browse the repository at this point in the history
  • Loading branch information
vweevers committed Sep 11, 2021
1 parent b8ec6a0 commit be7d6e4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ We aim to support _at least_ Active LTS and Current Node.js releases, Electron 5
The `leveldown` npm package ships with prebuilt binaries for popular 64-bit platforms as well as ARM, M1, Android and Alpine (musl) and is known to work on:

- **Linux** (including ARM platforms such as Raspberry Pi and Kindle)
- **Mac OS** (10.10 and later)
- **Mac OS** (10.7 and later)
- **Solaris** (SmartOS & Nodejitsu)
- **FreeBSD**
- **Windows**
Expand Down
3 changes: 2 additions & 1 deletion binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"GCC_SYMBOLS_PRIVATE_EXTERN": "YES",

# Set minimum target version because we're building on newer
"MACOSX_DEPLOYMENT_TARGET": "10.10",
# Same as https://github.com/nodejs/node/blob/v10.0.0/common.gypi#L416
"MACOSX_DEPLOYMENT_TARGET": "10.7",

# Build universal binary to support M1 (Apple silicon)
"OTHER_CFLAGS": [
Expand Down
2 changes: 1 addition & 1 deletion deps/leveldb/leveldb.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
],

# Set minimum target version because we're building on newer
"MACOSX_DEPLOYMENT_TARGET": "10.10",
"MACOSX_DEPLOYMENT_TARGET": "10.7",

# Build universal binary to support M1 (Apple silicon)
"OTHER_CFLAGS": [
Expand Down
2 changes: 1 addition & 1 deletion deps/snappy/snappy.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
],

# Set minimum target version because we're building on newer
"MACOSX_DEPLOYMENT_TARGET": "10.10",
"MACOSX_DEPLOYMENT_TARGET": "10.7",

# Build universal binary to support M1 (Apple silicon)
"OTHER_CFLAGS": [
Expand Down

0 comments on commit be7d6e4

Please # to comment.