Type casting inconsistency #174

Avoid overflows by casting to the larger type, zero-extended
LibreDWG · Dec 26, 2019 · 631bbac · 631bbac
1 parent b5819bf
commit 631bbac
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Makefile.am b/Makefile.am
@@ -127,7 +127,7 @@ check-dxf: all
 	  done; \
 	done
 
-# clang-analyzer.llvm.org, debian: clang-tools-{6.0,7}
+# clang-analyzer.llvm.org, debian: clang-tools-{6.0,7}, redhat: clang-analyzer
 SCAN_BUILD = scan-build
 scan-build: clean
 	$(SCAN_BUILD) -V -o .analysis $(MAKE) -j4 &

diff --git a/src/decode.c b/src/decode.c
@@ -2572,7 +2572,7 @@ read_2004_section_handles (Bit_Chain *restrict dat, Dwg_Data *restrict dwg)
         }
 
       last_offset = 0;
-      while ((int)(hdl_dat.byte - startpos) < section_size)
+      while ((long)(hdl_dat.byte - startpos) < (long)section_size)
         {
           int added;
           BITCODE_UMC handleoff;

diff --git a/src/decode_r2007.c b/src/decode_r2007.c
@@ -1591,7 +1591,7 @@ read_2007_section_handles (Bit_Chain *dat, Bit_Chain *hdl,
         }
 
       last_offset = 0;
-      while (hdl_dat.byte - startpos < section_size)
+      while ((long)(hdl_dat.byte - startpos) < (long)section_size)
         {
           int added;
           BITCODE_UMC handleoff;