Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

rename *_count fields to num* #8

Closed
rurban opened this issue May 25, 2018 · 1 comment
Closed

rename *_count fields to num* #8

rurban opened this issue May 25, 2018 · 1 comment
Assignees
@rurban
Milestone
0.5

Comments

@rurban
Copy link
Contributor

rurban commented May 25, 2018 •
edited
Loading

for consistency

include/dwg.h:  BITCODE_BL frozen_layer_count;
include/dwg.h:  BITCODE_BL instance_count; /* 91 Instance count for a custom class */
include/dwg.h:  BITCODE_BL owned_obj_count;
include/dwg.h:  BITCODE_BL owned_object_count;
include/dwg.h:  BITCODE_BS attr_def_count;
include/dwg.h:  BITCODE_BS m_vert_count;
include/dwg.h:  BITCODE_BS n_vert_count;
include/dwg.h:  BITCODE_RL insert_count;
include/dwg.h:dwg_get_entity_count(const Dwg_Data *);
include/dwg.h:dwg_get_layer_count(const Dwg_Data *);
include/dwg.h:dwg_get_object_count(const Dwg_Data *dwg);
include/dwg.h:dwg_get_object_object_count(const Dwg_Data *dwg);

e.g. dwg_get_numobjects, dwg_get_numentities, numfrozen_layers, ...

we have way more num* fields than _count.
@rurban rurban added this to the 0.5 milestone May 25, 2018
@rurban rurban self-assigned this May 25, 2018
rurban added a commit that referenced this issue May 26, 2018
@rurban
api: rename *_count fields to num*
464406c 
owned_obj_count + owned_object_count => num_owned
insert_count => num_inserts
instance_count => num_instances
frozen_layer_count => num_frozen_layers
FIELD_INSERT_COUNT => FIELD_NUM_INSERTS
object_count => num_objects: dwg_get_num_objects already existed in dwg.h
                             remove duplicate from dwg_api.h
entity_count => num_entities: dwg_get_num_entities already existed in dwg.h
	 		      remove duplicate from dwg_api.h
m_vert_count => num_m_verts
n_vert_count => num_n_verts
attr_def_count => num_attr_defs

Closes [GH #8]
@rurban
Copy link
Contributor Author

rurban commented May 26, 2018

done with 464406c

@rurban rurban closed this as completed May 26, 2018
This was referenced Jan 16, 2020
Closed
Closed
This was referenced Jul 18, 2020
Closed
Closed
This was referenced Jun 7, 2022
Closed
Closed
Closed
@iorra-cifer iorra-cifer mentioned this issue Nov 13, 2022
Closed
@iorra-cifer iorra-cifer mentioned this issue Nov 30, 2022
Closed
This was referenced Nov 28, 2023
Closed
Closed
@SEU-SSL SEU-SSL mentioned this issue Jun 28, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rurban rurban

Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@rurban