Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

api: remove array num setters, add add/delete api #9

Closed
rurban opened this issue May 26, 2018 · 1 comment
Closed

api: remove array num setters, add add/delete api #9

rurban opened this issue May 26, 2018 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rurban
Copy link
Contributor

rurban commented May 26, 2018

there exist various api functions to change the number of some elements without changing the associated array itself, e.g. dwg_ent_polyline_mesh_set_num_n_verts without setting the n_verts array.

all the set_num_ api functions need to go, and maybe add array add (at the end) and delete (at some index).

@rurban rurban added this to the 0.5 milestone May 26, 2018
@rurban rurban added the bug Something isn't working label May 26, 2018
@rurban rurban self-assigned this May 26, 2018
rurban added a commit that referenced this issue May 26, 2018
there exist various api functions to change the number of some elements
without changing the associated array itself, e.g.
dwg_ent_polyline_mesh_set_num_n_verts without setting the n_verts array.
all the set_num_ api functions need to go.
this is unsafe.

set_num_owned, set_numcols, set_numrows, set_num_lines, ...
See [GH #9]

not yet added add_array (i.e. push) and delete_array(at_index) apis yet.
@rurban
Copy link
Contributor Author

rurban commented May 26, 2018

deleted the dangerous setters with 39a6fe3

Will add array api's later eventually, if needed. Might be tricky to adjust all the handles and related other objects.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant