Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clarify the docs due to differences between Visium and Visium SPG processing pipeline steps #18

Open
lcolladotor opened this issue Mar 16, 2023 · 2 comments

Comments

@lcolladotor
Copy link
Member

Hi,

From today's spatial meeting, it sounds like there's a need to clarify the two types of .mat files in Visium and Visium Spatial Proteogenomics (Visium-SPG) processing pipelines, to avoid this confusion in the future. Otherwise you get a silent error: you get numbers but they are not the right ones.

This could be an excellent opportunity for Uma @Ukaipa9 / Boyi @boyiguo1 to learn / practice sending pull requests. Request a DSgs with Nick @Nick-Eagles if you need to learn more about pull requests.

Thanks!
Leo

@lcolladotor lcolladotor changed the title Clarify the docs a bit with differences between Visium and Visium SPG processing pipeline differences Clarify the docs due to differences between Visium and Visium SPG processing pipeline steps Mar 16, 2023
@madhavitippani
Copy link
Collaborator

HI @boyiguo1 CAN YOU REMIND ME WHAT THESE FILES ARE, SORRY I FORGOT.

@boyiguo1
Copy link

@madhavitippani This is relevant to the improvement that you and @Ukaipa9 worked on recently to allow counting for different protein channels of Visium SPG.

And the two types of .mat refers to the outcomes of splitSlide and refineVNS. If you feed splitSlide .mat outcome
to countNuclei, there are still results instead of a warning.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants