Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: pin version in links to external docs #236

Merged
merged 9 commits into from
Mar 6, 2024
Merged

docs: pin version in links to external docs #236

merged 9 commits into from
Mar 6, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 6, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

Implementing Lightning-AI/pytorch-lightning#19550 (comment)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--236.org.readthedocs.build/en/236/

@Borda Borda requested review from carmocca and awaelchli as code owners March 6, 2024 12:20
@Borda Borda added the enhancement New feature or request label Mar 6, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 6, 2024
@Borda
Copy link
Member Author

Borda commented Mar 6, 2024

adding unitests on pending on temp_docs fixture from #237

@github-actions github-actions bot added the tests label Mar 6, 2024
@Borda Borda merged commit 07ea2f3 into main Mar 6, 2024
45 checks passed
@Borda Borda deleted the docs/versions branch March 6, 2024 19:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies documentation Improvements or additions to documentation enhancement New feature or request package tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants