Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

False positive DMLStatementInLoop #86

Closed
jdayment opened this issue May 16, 2024 · 6 comments
Closed

False positive DMLStatementInLoop #86

jdayment opened this issue May 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@jdayment
Copy link

I started a new project and downloaded the flows into a new folder when running the scan I get a false positive for DML Inside Loop on any flow that includes a loop and assignment it seems that scan resulted in 501 of the 640 flows in the org having a DML Inside Loop. Other results are accurate i.e. SOQL in Loop. On Windows 11 in VSCODE

@RubenHalman
Copy link
Member

@jdayment what solution are you using?

@RubenHalman RubenHalman reopened this May 20, 2024
@jdayment
Copy link
Author

@RubenHalman I am using the Lightning Flow Scanner VSCODE Extension
v3.14.0

@nvuillam
Copy link
Contributor

oops didn't want to close the issue, just to reference it from a commit on another repo ^^

@RubenHalman RubenHalman added the bug Something isn't working label May 21, 2024
@RubenHalman RubenHalman transferred this issue from Lightning-Flow-Scanner/lightning-flow-scanner-vsce May 21, 2024
@RubenHalman RubenHalman changed the title False Positives False positive DMLStatementInLoop May 21, 2024
@RubenHalman
Copy link
Member

@nvuillam and @jdayment I believe this issue was present in both sfdx and vsce, but should be resolved with our latest version thanks to input from @patrykacc Please let me know if this issue remains

@jdayment
Copy link
Author

@RubenHalman Looks like it's fixed on my end thanks @patrykacc!

@RubenHalman
Copy link
Member

Thank you, @jdayment, @nvuillam & @patrykacc for providing the necessary feedback and help! I will close this issue, but please feel free to let us know if anything!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants