-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bump: compatible with Lightning
v2
#1094
base: master
Are you sure you want to change the base?
Conversation
I believe that some of the checks are failing for reasons unrelated to changes in this PR e.g. "Roms.rar is not RAR archive" in ubuntu-20.04, 3.8, latest. I also haven't updated documentation as unsure where would be best to do so for this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add description, I guess you try to bump dependency to lightning v2, right?
Yes, sorry! I've updated it now. |
Hi. @Borda can this PR be merged (and hopefully pushed to PyPI) or is there something blocking it? The |
Is there any other blocker here ? I saw that there was a merge requested but it never merged to this repo's main. I can help out if there are any other changes that are required or if anything is blocking the merge. |
What does this PR do?
Bumps to lightning 2 as per #1067
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://lightning-bolts--1094.org.readthedocs.build/en/1094/