BEEFY consensus message scale classes #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plemented scale reading. Introduced beefy consensus message processing in addBlockToTree() method (without implementation of the handler).
hMitov
changed the title
hMitov
changed the title
Grigorov-Georgi
approved these changes
Feb 20, 2025
georg-getz
reviewed
Feb 20, 2025
| switch (format) { | ||
| case BEEFY_CHANGED_AUTHORITIES -> { | ||
| List<byte[]> authorityPublicKeys = new ListReader<>( | ||
| rdr -> rdr.readByteArray(33)).read(reader); |
There was a problem hiding this comment.
can you create a constant for that 33, it feels like a magic number right now.
Zurcusa
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Each digest is added separately in the header. This means we can have more than one digest per type. With the current implementation we use findFirst() and that would not work. I suggest we rework the getBabeConsensusMessage, getGrandpaConsensusMessage, getBeefyConsensusMessage so that they return a list of scale decoded messages instead of a single option.
…ore than one digest message from a type.
|
Zurcusa
approved these changes
Feb 21, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #771