Skip to content
This repository was archived by the owner on Aug 5, 2021. It is now read-only.

Naming inconsistencies - Rename the compile parameter from dir to path #272

Open
Daniel-K-Ivanov opened this issue Aug 13, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@Daniel-K-Ivanov
Copy link
Member

Currently there are inconsistencies for the naming of different parameters. For example:
When doing compile, the parameter for the path is dir

etherlime compile --dir {dir}

When testing, the parameter is path.

etherlime test --path {path}

When using coverage the parameter is path as-well

and when deploying the parameter is file

etherlime deploy --file {file}

For the deploy, it is okay to be file, however when it comes to directories, I think it would be best to have consistent naming of the parameters, because everytime I do compile or test, I go into the docs and whether I needed to do dir, path or file

Proposed solution:
Change the etherlime compile parameter to path as-well

@Daniel-K-Ivanov Daniel-K-Ivanov added the enhancement New feature or request label Aug 13, 2019
@Daniel-K-Ivanov Daniel-K-Ivanov changed the title Naming inconsistencies - Rename the compile path to path and not dir Naming inconsistencies - Rename the compile parameter from dir to path Aug 13, 2019
Perseverance added a commit that referenced this issue Oct 21, 2019
[#272] fix etherlime compile optional param dir to path
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant