Skip to content

Commit

Permalink
Fixed how the vault path is found on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
Linus-Mussmaecher committed Jul 28, 2024
1 parent 865824b commit 6442084
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
# Version 0.3.4 - Operating System Support

## Features
- Rucola can now be installed via homebrew
- Added a title to the select screen
- Added the current rucola version to both screens
- Added a build script that copies the 5 default configuration files in the configuration folder on install.
- The display screen now only shows unique links and backlinks. The select screen continues to count links (not linking notes), so linking note A twice from note B will count as two outlinks for A, two inlinks for B, but now B will only show up once in the backlinks list of A and A will only show up once in the links list of B.

## Bugfixes
- Pathes are now canonicalized before being sent to external commands or used to create a file watcher, solving some issues previously appearing on Windows where mixing forward and backwards slashes would cause problems.
- Windows now correctly uses the path from command line arguments and the config file
- Slightly altered CSS integration to work around a firefox/windows issue requiring `file://` before an absolute CSS path.


# Version 0.3.3 - Fixing Release
Fixed problems with `cargo dist`, fully removed homebrew.
Expand Down
9 changes: 6 additions & 3 deletions src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,13 @@ impl Config {
#[cfg(not(target_family = "unix"))]
fn vault_path(
pwd: path::PathBuf,
_args: crate::Arguments,
_config: &mut Config,
args: crate::Arguments,
config: &mut Config,
) -> path::PathBuf {
pwd
args.target_folder
.map(|folder_string| path::PathBuf::from(folder_string))
.or(config.vault_path.take())
.unwrap_or_else(|| pwd.clone())
}

/// Expanduser expands `~` to the correct user home directory and similar, on unix systems.
Expand Down

0 comments on commit 6442084

Please # to comment.