Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix docker build #769

Merged
merged 4 commits into from
Dec 18, 2024
Merged

fix docker build #769

merged 4 commits into from
Dec 18, 2024

Conversation

simono41
Copy link
Contributor

No description provided.

Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I would use the existing value inside the pubspec.yaml to get the flutter version

@simono41
Copy link
Contributor Author

simono41 commented Dec 18, 2024

As a small note, you have to change the right port area on the page to port 80 with the docker run command: https://butterfly.linwood.dev/downloads/selfhosting/

The default port of nginx is the port 80

@CodeDoctorDE
Copy link
Member

Oh yeah, feel free to change it too, you can find it in docs/community/downloads/web.mdx.
don't we also need a EXPOSE 80 in the docker file?
Also: Do we need to add support for https or should people add a reverse proxy before routing it in here?

I will test it once I'm on my linux computer

@simono41
Copy link
Contributor Author

Oh yeah, feel free to change it too, you can find it in docs/community/downloads/web.mdx. don't we also need a EXPOSE 80 in the docker file? Also: Do we need to add support for https or should people add a reverse proxy before routing it in here?

I will test it once I'm on my linux computer

All right, I'll edit the mdx file and add the EXPOSE 80.

I would not suggest adding https support for the reverse proxy because SSL certificates must first be obtained via letś encrypt or zerossl via the acme program.

In my case, I have a second Nginx as a reverse proxy to make my other services accessible under the same domain.

@CodeDoctorDE
Copy link
Member

Looks good now, just add "--wasm" to the flutter build to allow the new webassembly files that should allow better performance

Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, for this we also need to change the nginx.conf maybe to allow extra permissions, I will merge it now and we could work from there.
see https://docs.flutter.dev/platform-integration/web/wasm for the configuration details

@CodeDoctorDE CodeDoctorDE merged commit 6ce4742 into LinwoodDev:develop Dec 18, 2024
@CodeDoctorDE
Copy link
Member

thanks for the contribution :)

Some next steps we could do:

  • Add wasm
  • Add workflow to publish it on dockerhub

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants