Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update and add links for vim editor support #446

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

Jach
Copy link
Contributor

@Jach Jach commented Apr 24, 2022

Though there haven't been many changes to Slimv since the 2017 release on vim.org, the biggest change being some basic stepper support, I think it's more expected these days to have links to a project's development home.

I also think other vim users will be interested in the linked blog post to help them decide which of the two plugins to try.

@vindarel
Copy link
Contributor

Good points. We avoid linking to blog posts in the middle of the page though. We either write content, either use the section for that at the bottom.

@Jach
Copy link
Contributor Author

Jach commented Apr 25, 2022

Yeah, agreed it's better to have self-contained content. But some already existing pages are just really useful and not directly findable from existing links (like it'd be redundant to link to slimv's own tutorial since it's part of its readme), and I noticed the link just above in the emacs section that goes out to wikemacs indicating an exception to self-contained content.

I can remove the blog link completely if you think that's best and just make this PR about updating the slimv link, but I'm happy/somewhat expected to bikeshed a bit on the proper formatting to include the blog post. It wasn't clear to me that the screenshot really denoted a 'sectioning' so it made most sense initially to put the link close to the two things it's about. To check that I understand what you mean by the section at the bottom, do you just mean adding something like:

See also:

  • link

Below the slimv_box line and above the Atom section? Or make an explicit subsection there like "Using Slimv and Vlime with Vim" and putting the link inside that, and ideally one day replacing it with or adding a self-contained cookbook page?

@vindarel
Copy link
Contributor

vindarel commented Jun 1, 2022

yes, can you add this "See also… link" at the end of the Vim entry, above he Atom section?

* Change the link for Slimv to the github homepage
* Add an external link to a blog post demonstrating and comparing the
  two vim plugins
@jgarte
Copy link
Collaborator

jgarte commented Dec 27, 2022

@Jach @vindarel

Hi, is this still being worked on?

@Jach
Copy link
Contributor Author

Jach commented Dec 29, 2022

I made the changes requested, so nothing else from my side I think

@vindarel vindarel merged commit f302a23 into LispCookbook:master Dec 29, 2022
@vindarel
Copy link
Contributor

Thanks both!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants