Fix report filter reporting stale Redux data (LF-3958)

LiteFarmOrg · Mar 7, 2025 · a032055 · a032055
1 parent a5f8a30
commit a032055
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/packages/webapp/src/containers/Finances/Report/index.jsx b/packages/webapp/src/containers/Finances/Report/index.jsx
@@ -62,14 +62,12 @@ const Report = () => {
     revenueTypeFilter: typesFilter?.[REVENUE_TYPE],
   });
 
-  // If dashboard filters change, update report filters
-  useEffect(() => {
+  // Refresh report filters according to current dashboard filters when opening modal
+  const openExportReport = () => {
     setDateFilter(dashboardDateFilter);
-  }, [dashboardDateFilter]);
-
-  useEffect(() => {
     setTypesFilter(dashboardTypesFilter);
-  }, [dashboardTypesFilter]);
+    setIsExportReportOpen(true);
+  };
 
   const onValidityChange = (isValid) => {
     setIsButtonDisabled(!isValid);
@@ -176,7 +174,7 @@ const Report = () => {
 
   return (
     <div>
-      <TextButton onClick={() => setIsExportReportOpen(true)} className={styles.reportButton}>
+      <TextButton onClick={openExportReport} className={styles.reportButton}>
         <ReportIcon />
         {t('SALE.FINANCES.REPORT')}
       </TextButton>