Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

enable pnpm symlink to fix memory vite build memory issue #2497

Merged
merged 1 commit into from
Mar 17, 2023
Merged

enable pnpm symlink to fix memory vite build memory issue #2497

merged 1 commit into from
Mar 17, 2023

Conversation

JimmyRowland
Copy link
Collaborator

Description
vite build failure due to beta server memory limitations

Jira link:
Please see #2495, which still produced a JavaScript heap memory error (with 4GB of memory allocated).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This will be tested by running deploy upon merge.

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@JimmyRowland JimmyRowland mentioned this pull request Mar 17, 2023
Closed
13 tasks
Duncan-Brain
Duncan-Brain approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@Duncan-Brain Duncan-Brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try it

@SayakaOno SayakaOno merged commit c60f4cb into integration Mar 17, 2023
kathyavini added a commit that referenced this pull request Mar 21, 2023
@kathyavini
Revert "Merge pull request #2497 from LiteFarmOrg/fix-vite-build-memo…
9f030f1 
…ry-issue"

This reverts commit c60f4cb, reversing
changes made to 39a09d8.
This was referenced Mar 21, 2023
Closed
Merged
@Duncan-Brain Duncan-Brain mentioned this pull request May 30, 2023
Closed
16 tasks
@iperdomo iperdomo deleted the fix-vite-build-memory-issue branch June 2, 2023 11:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Duncan-Brain Duncan-Brain Duncan-Brain approved these changes

@SayakaOno SayakaOno SayakaOno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JimmyRowland @Duncan-Brain @SayakaOno