-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
LF-4349 Finish crowdin setup to support the addition of new languages #3343
LF-4349 Finish crowdin setup to support the addition of new languages #3343
Conversation
Question: should we also remove the auto trigger for integration branch upload? |
@Duncan-Brain I'm totally happy to remove the auto-trigger! It sounds like we won't return to integration-based development for a long time and the manual dispatch has been fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will want a PR to add these changes on main too right for it to work there? (I assume thats what the workflow inputs thing meant)
Yup, I was thinking to clear the CrowdIn sources and do more testing while it's on integration, and if checks out, open PR against main (just to keep down the number of commits added to main) in case something is not right yet. |
…p-to-support-the-addition-of-new-languages LF-4349 Finish crowdin setup to support the addition of new languages
Description
As just discussed a few minutes ago 🙂
GitHub variablesdispatch inputs (with fallback to false) so they can be changed without having to merge new versions of these filesTesting plan:
Jira link: https://lite-farm.atlassian.net/browse/LF-4349
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Can't test; actions workflow 🙁
Checklist: