Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LF-4349 Finish crowdin setup to support the addition of new languages #3343

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Jul 29, 2024

Description

As just discussed a few minutes ago 🙂

  • Add the {{ matrix.locales }} to each PR title to disambiguate them
  • Make upload translations and auto-approve uploaded GitHub variables dispatch inputs (with fallback to false) so they can be changed without having to merge new versions of these files

Testing plan:

  • variables have been set on the repository level
  • this is opened against integration; once merged I will test toggling the environmental variables and running the upload to make sure it behaves as expected
  • if successful I will open a new PR to merge to main

Jira link: https://lite-farm.atlassian.net/browse/LF-4349

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Can't test; actions workflow 🙁

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini added the enhancement New feature or request label Jul 29, 2024
@kathyavini kathyavini self-assigned this Jul 29, 2024
@kathyavini kathyavini requested review from a team as code owners July 29, 2024 16:53
@kathyavini kathyavini requested review from Duncan-Brain and SayakaOno and removed request for a team July 29, 2024 16:53
@Duncan-Brain
Copy link
Collaborator

Question: should we also remove the auto trigger for integration branch upload?

@kathyavini
Copy link
Collaborator Author

kathyavini commented Jul 29, 2024

@Duncan-Brain I'm totally happy to remove the auto-trigger! It sounds like we won't return to integration-based development for a long time and the manual dispatch has been fine.

Copy link
Collaborator

@Duncan-Brain Duncan-Brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want a PR to add these changes on main too right for it to work there? (I assume thats what the workflow inputs thing meant)

@kathyavini
Copy link
Collaborator Author

kathyavini commented Jul 29, 2024

We will want a PR to add these changes on main too right for it to work there? (I assume thats what the workflow inputs thing meant)

Yup, I was thinking to clear the CrowdIn sources and do more testing while it's on integration, and if checks out, open PR against main (just to keep down the number of commits added to main) in case something is not right yet.

@SayakaOno SayakaOno added this pull request to the merge queue Jul 29, 2024
Merged via the queue into integration with commit 4ef20db Jul 29, 2024
4 of 5 checks passed
kathyavini pushed a commit that referenced this pull request Jul 29, 2024
…p-to-support-the-addition-of-new-languages

LF-4349 Finish crowdin setup to support the addition of new languages
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants