Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adjust Ensemble sensor GET to handle missing paramter_types #3706

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Mar 6, 2025

Description

This is not a full-fledged solution for the problem of the Ensemble API maybe being in flux, this is just restoring our Sensor List for now.

paramter_types is no longer returned from the device endpoint. Actually I don't think the info has been replaced yet -- I see a property paramaters but it is null. Maybe parameter_types will be restored? I'm not sure.

As of yet I don't think the frontend uses it so it may be safe to remove entirely in the future when we revisit the Ensemble device endpoint closer to release.

Jira link: none

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

There are Sentry errors and everything for this :) Based on the timing I guess the Ensemble API was changed yesterday.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini added the bug Something isn't working label Mar 6, 2025
@kathyavini kathyavini self-assigned this Mar 6, 2025
@kathyavini kathyavini requested review from a team as code owners March 6, 2025 00:22
@kathyavini kathyavini requested review from Duncan-Brain and SayakaOno and removed request for a team March 6, 2025 00:22
@Duncan-Brain Duncan-Brain added this pull request to the merge queue Mar 7, 2025
Merged via the queue into integration with commit 13b44d7 Mar 7, 2025
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants