enhancement: disable autoplay from AudioPlayer and hides all controls except "Play" at startup #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
AkesiSeli
force-pushed
the
fix-audio-autoplay
branch
from
ef3e4ca to
5de57c9
Compare
AkesiSeli
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical details
This PR prevents audio files from automatically start playing and hides all controls except "Play" at startup, as requested in #688.
Additional notes
Unfortunately, there is no simple way to accomplish this using Compose Multiplatform Media Player, so I had to create a "fake" interface of a paused player which shows the real player when the play button is pressed.