fix: create and edit posts with attachments on Friendica #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
AkesiSeli
force-pushed
the
fix-alt-text-in-post-creation-and-edit
branch
from
c83e0c0 to
3d44e13
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical details
This PR fixes a bug accidentally introduced in #643 while fixing #640. Apparently, just on Friendica, you have to call different APIs to edit an image alt-text depending on whether it is a new post or an edit of an existing post. It does not matter whether the image is already uploaded to your gallery, it still behaves differently when it is attached or not to an existing post.
Additional notes
This looks like a server "bug" which is being worked around by either calling POST
friendica/photo/updateor PUTv1/media/:idbut I imagine the backenders have some good reasons to implement this feature like this.This PR will remain as a documentation in case someone else needs some reference.