Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(di): migrate to Koin Annotations • 3 #139

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

AkesiSeli
Copy link
Contributor

Technical details

This PR migrates all feature and unit modules to Koin annotations. At last, the migration is complete!

@AkesiSeli AkesiSeli self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ure/profile/notlogged/ProfileNotLoggedViewModel.kt 83.33% 0 Missing and 1 partial ⚠️
Flag Coverage Δ
unittests 47.85% <93.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ccoonforlemmy/feature/inbox/main/InboxViewModel.kt 96.61% <ø> (ø)
...lemmy/feature/profile/main/ProfileMainViewModel.kt 100.00% <100.00%> (ø)
...y/feature/profile/menu/ProfileSideMenuViewModel.kt 0.00% <ø> (ø)
...otlin/com/livefast/eattrash/raccoonforlemmy/App.kt 0.00% <ø> (ø)
...ure/profile/notlogged/ProfileNotLoggedViewModel.kt 93.33% <83.33%> (+0.47%) ⬆️

@AkesiSeli AkesiSeli merged commit 8f9afce into master Dec 6, 2024
3 checks passed
@AkesiSeli AkesiSeli deleted the migrate-to-koin-annotations-3 branch December 6, 2024 22:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant