Fix Bounding Box Calculation #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point when changing our text engine, we introduced a scale value for each individual glyph, possibly during the transition to `cosmic-text`. This is correctly being used when rendering the text, but not when calculating the bounding box of the text. This meant that for certain fonts the dirty region of the image, that is cleared on each frame was not calculated correctly and thus the previous text was still visible.
CryZe
added
bug
It got renamed to mention the version number in the target name.
CryZe
force-pushed
the
bounding-box-calc
branch
from
c99295b to
14e7900
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point when changing our text engine, we introduced a scale value for each individual glyph, possibly during the transition to
cosmic-text. This is correctly being used when rendering the text, but not when calculating the bounding box of the text. This meant that for certain fonts the dirty region of the image, that is cleared on each frame, was not calculated correctly and thus the previous text was still visible.