Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Blocks Patterns & Blocks Pattern Categories Registration: Remove is_admin() condition #40

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

ouun
Copy link
Contributor

@ouun ouun commented Jun 12, 2022

is_admin() is not reliable in this conext. Block Pattern Categories are not available in the editor as long as the condition is used.

`is_admin()` is not reliable in this conext. Block Pattern Categories are not available in the editor as long as the condition is used.
@ouun ouun changed the title Remove is_admin() condition Fix Blocks Pattern Categories Registration: Remove is_admin() condition Jun 12, 2022
@vdrnn
Copy link

vdrnn commented Jun 12, 2022

@ouun same for registerin block patterns. Maybe you can add the fix to https://github.com/Log1x/poet/blob/master/src/Modules/BlockPatternModule.php#L28 too in the same pull request.

is_admin() is not reliable in this conext. Block Pattern Categories are not available in the editor as long as the condition is used.
@ouun ouun changed the title Fix Blocks Pattern Categories Registration: Remove is_admin() condition Fix Blocks Patterns & Blocks Pattern Categories Registration: Remove is_admin() condition Jun 13, 2022
@Log1x Log1x merged commit 709c535 into Log1x:master Jun 13, 2022
@Log1x
Copy link
Owner

Log1x commented Jun 13, 2022

Thank you!

@ouun ouun deleted the patch-1 branch June 13, 2022 09:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants