Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: added babel transform-object-assign to fix IE support #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pwntastic
Copy link

Using native Object.assign was breaking IE support, so I pulled in babel-plugin-transform-object-assign to add in a polyfill when necessary.

Also the linter was complaining about the quotes around TRACE so I fixed that too.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@539dab5). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #255   +/-   ##
=======================================
  Coverage          ?    82%           
=======================================
  Files             ?      5           
  Lines             ?    150           
  Branches          ?      0           
=======================================
  Hits              ?    123           
  Misses            ?     27           
  Partials          ?      0
Impacted Files Coverage Δ
src/core.js 73.33% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539dab5...bc923ec. Read the comment docs.

@cyberhck
Copy link

what's going on with this one? why is this PR not merged?

@Pwntastic
Copy link
Author

Is there anything that I specifically need to do?

@cyberhck
Copy link

cyberhck commented Sep 28, 2017

it almost looks like author of this repo didn't even look at this PR 😄

BTW to make tests pass, you need to ADD some tests, reason those are failing is because redux-logger doesn't have enough test coverage.

@z-vr
Copy link

z-vr commented Nov 15, 2017

just spent an hour figuring it out, can this be merged please.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants