MTProtoSender: Dont try to reconnenct in background when auto_reconnect is not available #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct flag is not active
Lonami
requested changes
Apr 17, 2024
There was a problem hiding this comment.
_start_reconnect is called from separate tasks. Raising the error there won't let you catch it, and the library will appear to freeze.
Please make sure to try out the changes before I accept. You can edit the code to randomly force an error (maybe check when a file exists, and create the file to trigger it), for example, and see if it works as expected.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this PR to fix this issue:
#4092