Skip to content

#2218 add emoji to foodType on watch #2230

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

#2218 add emoji to foodType on watch #2230

merged 1 commit into from
Apr 17, 2025

Conversation

Joerg-Schoemer
Copy link
Contributor

@Joerg-Schoemer Joerg-Schoemer commented Sep 22, 2024 •
edited by marionbarker
Loading

Purpose

This PR fixes Issue #2218

@Joerg-Schoemer
LoopKit#2218 add emoji to foodType
99cf9a6 
Signed-off-by: Jörg Schömer <joerg@joerg-schoemer.de>
@Joerg-Schoemer Joerg-Schoemer changed the title #2218 add emoji to foodType #2218 add emoji to foodType on watch Sep 23, 2024
@marionbarker
Copy link
Contributor

Test

I tested this on my personal Loop phone. (iPhone 15 pro running iOS 18.3.2 with Loop 3.4.4)

Confirm bug

First, I entered carbs from watch using pizza icon.

  • The icon was not shown in the ICE screen.

Confirm fix

I then modified my code using this change and rebuilt.

  • I removed Loop from my watch complications (which allows new Loop app to install on the watch)
  • After installation, I added Loop back to my watch complications
  • I entered carbs from watch using pizza icon.
  • The pizza icon now shows up on the ICE screen

marionbarker
marionbarker approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code change and tested.
LGTM.

@ps2 ps2 self-requested a review April 17, 2025 18:21
ps2
ps2 approved these changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marionbarker marionbarker merged commit 3d6f2ec into LoopKit:dev Apr 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ps2 ps2 ps2 approved these changes

@marionbarker marionbarker marionbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joerg-Schoemer @marionbarker @ps2