Skip to content

update progressCell for bolus display for tidepool-merge #2263

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

marionbarker
Copy link
Contributor

Purpose:

This PR fixes an intermittent bolus progress display error reported in these issues

@itsmojo identified root cause for this intermittent display error and passed on a proposed fix for the main branch.

If a bolus progress is being displayed when the app is put into background and then the app is opened in the middle of a bolus, the progress bar shows a stale value of the expected total units; the stale value is the total units from the last time the bolus progress bar was displayed.

I tested the tidepool-merge build using this test method and showed the intermittent display error occurs with tidepool-merge as well as main. The fix from @itsmojo was modified to work with the new tidepool-merge version of the Loop/View Controllers/StatusTableViewController.swift file.

Test

This PR was applied to tidepool-merge. The same test method mentioned above was used and every instance of opening the app in the middle of a bolus showed the correct value for the total bolus units.

@marionbarker marionbarker changed the title update progressCell for bolus display update progressCell for bolus display for tidepool-merge Mar 21, 2025
@marionbarker marionbarker requested a review from ps2 March 21, 2025 14:54
Copy link
Collaborator

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marionbarker marionbarker merged commit 5fbdd9b into LoopKit:tidepool-merge Mar 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants