update progressCell for bolus display, finish update for dev branch

[marionbarker]

Purpose:

This PR should resolve Issue #2196.

I failed to test PR #2295, which was supposed to resolve the issue, in a LoopWorkspace build.

As explained here, I was given a version of the patch that worked with dev, but had to modify it for tidepool-merge.

LoopWorkspace Status

The dev branch of LoopWorkspace is still pointing to an earlier commit for Loop, so my mistake in PR 2295 does not affect LoopWorkspace dev.

Tests

Build and Run Tests

With the addition of this PR to Loop dev (commit 710182e, resultant commit prior to merge: 46f7a49):

• building LoopWorkspace to a phone simulator succeeds
• running the Tests all succeed

My next comment will cover testing using a Test Phone to demonstrate the UI glitch is resolved.

[marionbarker]

Test Efficacy

Tested that this PR fixed Issue #2196.

Configuration

• iPhone SE 3rd generation using Nightscout as a CGM and rPi DASH pod, use Automatic Bolus Dosing Strategy

Test Plan

• set CGM values to steady state (110 +/-1)
• add carbs but bolus 1 U (as opposed to recommended amount)
• as soon as Bolus Progress display is shown, lock the phone
• watch the rPi display and when the next bolus starts (insulin command is visible), unlock the phone

Confirm Error happens with older version

Error was confirmed

Details

Configure Loop to commit f63edf9 (before the fixes for Issue 2196)
Run Test:

• enter carbs, modify recommended bolus from 4.5 to 1.0 and bolus
• bolus progress before locking: 0.3 of 1.0 U
• bolus progress after unlocking, immediately after program insulin command is issued by rPi: 0.1 of 1.0 with final bolus progress showing 1.7 of 1.0 U.
• confirm the auto bolus was for 1.7 U

Test with code from this PR

Correct display of bolus total was confirmed

Details

Configure Loop to commit 46f7a49 (includes both commits to fix Issue 2196)
Run Test:

• enter carbs, modify recommended bolus from 8 to 1.0 and bolus
• bolus progress before locking: 0.1 of 1.0 U
• bolus progress after unlocking, immediately after program insulin command is issued by rPi: 0.1 of 2.9
• confirm the auto bolus was for 2.9 U

[itsmojo]

Looks good.