Toggle for disabling the retrospective correction #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a toggle in the algorithm experiments to disable the retrospective correction (standard or integral). It follows an explicit request from some patients and doctors, which are having troubles in understanding what is going on with ISFs and carb ratios because of the retrospective correction "masking" sub-optimal settings.
What is missing:
It would be also nice to rename the algorithm experiments section to “advanced” or something similar, shifting its purpose from a sort of parking lot for experimental features to a proper section for advanced features and options which are going to stay. This of course does not mean that one of them could become a new default, but it would be nice to have a bit of more control and variety of options.